Fix Transient fault handling issue with OpenAsync #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
- Coverage 70.59% 70.52% -0.07%
==========================================
Files 306 306
Lines 61667 61725 +58
==========================================
- Hits 43533 43532 -1
- Misses 18134 18193 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Nice. Thanks! |
DavoudEshtehari
approved these changes
Apr 14, 2023
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
JRahnama
approved these changes
Apr 19, 2023
kant2002
pushed a commit
to kant2002/SqlClient
that referenced
this pull request
Jun 29, 2023
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Oct 25, 2023
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
May 16, 2024
…ing issue with OpenAsync (dotnet#1983)" This reverts commit 80d1f47. # Conflicts: # src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
May 16, 2024
…ing issue with OpenAsync (dotnet#1983)" This reverts commit 80d1f47. # Conflicts: # src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
May 16, 2024
…with OpenAsync (dotnet#1983)" This reverts commit 80d1f47.
DavoudEshtehari
added a commit
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1982
'Retry', is a completion callback that is completed after
CreateConnection()completes (which handles transient faults), here:SqlClient/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs
Lines 1079 to 1095 in a5ad838
So I don't see a reason to not enable transient fault handling retries when its specified.